Closed Bug 899822 Opened 11 years ago Closed 11 years ago

Stop trying to sync LDAP sessions

Categories

(MailNews Core :: LDAP Integration, defect)

Product:
MailNews Core
Component:
LDAP Integration
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird25 fixed, seamonkey2.22 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 26.0
Tracking Flags:
Tracking Status
thunderbird25 --- fixed
seamonkey2.22 --- fixed

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Proposed patch
3.48 KB, patch
standard8
: review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review 
We're still trying to sync sessions between elements in the addressing widget, but this is unnecessary now that LDAP is using toolkit interfaces. I want to remove the API in bug 896123, so we should stop calling it!
Attached patch Proposed patch — — Splinter Review 
I also removed the comment column cloning because it's stored on an attribute so it gets cloned anyway.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #783416 - Flags: review?(mbanner)
(In reply to Mark Banner from comment #2)
> Could you also tidy the lightning instance around
> 
> http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/
> calendar-event-dialog-attendees.xml#426
> 
> ?

Ideally Lightning would ditch all of their old LDAP code in bug 899958.
Attachment #783416 - Flags: review?(mbanner) → review+
neil, can confirm that this will make the parts of the current patch for bug 61491 (which I am currently debitrotting) concerned with LDAP sessions obsolete?
Blocks: 61491
T(In reply to Jens Müller (:tessarakt) from comment #4)
> neil, can confirm that this will make the parts of the current patch for bug
> 61491 (which I am currently debitrotting) concerned with LDAP sessions
> obsolete?

In fact, the patch here is required to make the current patch for bug 61491 work.
Pushed comm-central changeset 657dea66cbd9.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
Comment on attachment 783416 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
This should have been done as part of bug 452232 which landed on TB25 so I sort of feel that this should too.
Attachment #783416 - Flags: approval-comm-aurora?
Comment on attachment 783416 [details] [diff] [review]
Proposed patch

Yep, good idea. a=Standard8
Attachment #783416 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: